rework prune rewrite with iterators #3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is purely a refactor. We have decent test coverage. Testing locally to ensure we can still prune/compact successfully. |
|
antiochp
added a commit
to antiochp/grin
that referenced
this pull request
Feb 22, 2021
This reverts commit 5092652.
antiochp
added a commit
that referenced
this pull request
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the handling of
pos_to_rmwhen pruning during compaction.We used to pass a slice
&[u64]around and this has been reworked to accept anIntoIterator<Item = u64>.This allows us to avoid
collect()in various places with intermediate memory allocation.Split
save_prune()into two functions for flexibility so we can pass an iterator into the earlierwrite_tmp_pruned()without needing&mut self(as the iterator passed in has a reference to immutable self).